-
Notifications
You must be signed in to change notification settings - Fork 141
Add support for parsing reified triples and triple terms #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Note this repo now uses semantic release, and this is a breaking change. Make sure to include |
Fingers crossed that the RDF WG sees it that way indeed 😉 Excellent work, @rubensworks. |
3a8218a
to
64a6ce0
Compare
@RubenVerborgh FYI, this now includes parsing of the new version directive (w3c/rdf-star-wg#141). |
@RubenVerborgh The new We could merge and release as soon as the specs either go to CR or Rec status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rubensworks All good, thanks a lot. This has been an impactful pull request.
Minor comments. Open question whether we also want to check (in the future) whether certain constructs are indeed version-allowed, like direction.
I'll leave the further handling to you, you can merge and publish as desired.
Thanks for the review @RubenVerborgh. |
For reference, the contents of this branch are now published as |
All good, comments were minor; do proceed. |
This removes RDF-star parsing and instead implements for triple terms and reified triples from RDF 1.2.
I just wanted to raise this PR already to avoid duplicate efforts.
Note that some spec tests fail, because not all of them have been updated yet: w3c/rdf-tests#161
Also note that this PR does not update the writer yet.
This PR builds on top of #484 and should only be merged after w3c/rdf-star-wg#141 is resolved.